netdev - Re: [PATCH net] amd-xgbe: Request IRQs only after driver is fully setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150227.171320.1659341988981769664.davem@davemloft.net>
Date:	Fri, 27 Feb 2015 17:13:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] amd-xgbe: Request IRQs only after driver is fully
 setup

From: Tom Lendacky <thomas.lendacky@....com>
Date: Wed, 25 Feb 2015 13:50:12 -0600

> It is possible that the hardware may not have been properly shutdown
> before this driver gets control, through use by firmware, for example.
> Until the driver is loaded, interrupts associated with the hardware
> could go pending. When the IRQs are requested napi support has not
> been initialized yet, but the ISR will get control and schedule napi
> processing resulting in a kernel panic because the poll routine has not
> been set.
> 
> Adjust the code so that the driver is fully ready to handle and process
> interrupts as soon as the IRQs are requested. This involves requesting
> and freeing IRQs during start and stop processing and ordering the napi
> add and delete calls appropriately.
> 
> Also adjust the powerup and powerdown routines to match the start and
> stop routines in regards to the ordering of tasks, including napi
> related calls.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>

This looks a lot better, applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html