lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20150227.172104.142920096639146096.davem@davemloft.net> Date: Fri, 27 Feb 2015 17:21:04 -0500 (EST) From: David Miller <davem@...emloft.net> To: jiri@...nulli.us Cc: sfeldma@...il.com, gospo@...ulusnetworks.com, andrew@...n.ch, zajec5@...il.com, f.fainelli@...il.com, netdev@...r.kernel.org, jogo@...nwrt.org, hauke@...ke-m.de, nbd@...nwrt.org Subject: Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches From: Jiri Pirko <jiri@...nulli.us> Date: Thu, 26 Feb 2015 15:44:33 +0100 > Thu, Feb 26, 2015 at 03:19:27PM CET, sfeldma@...il.com wrote: >>Missing .ndo_start_xmit is the clue....do we need more? > > You do not want to add null check for ndo_start_xmit to xmit path :) > This should be some stub in case of no-tx. Cheapest would be to force the device to use the noop_qdisc which simply throws all packets away. No fast path tests whatsoever. Or we can attach an ndo_start_xmit that drops packets too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists