netdev - Re: [PATCH net-next 1/2] net: davinci_mdio: don't request io address range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2015 15:55:34 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Mugunthan V N <mugunthanvnm@...com>, george.cherian@...com,
	varkabhadram@...il.com, netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	lokeshvutla@...com, mpa@...gutronix.de, w-kwok2@...com
Subject: Re: [PATCH net-next 1/2] net: davinci_mdio: don't request io address range

On Tue, Feb 24, 2015 at 9:27 PM, Murali Karicheri <m-karicheri2@...com> wrote:
> From: Grygorii Strashko <grygorii.strashko@...com>
>
> Historically Davinci MDIO driver was  created with assumption that
> MDIO is standalone device, but for Keystone 2 it's a part
> of NETCP module and now NETCP driver requests IO range which
> includes MDIO IO range too. This causes Keystone 2 networking stack
> failure during the boot.
>
> "netcp-1.0 2620110.netcp: Probe of module(netcp-gbe) failed with -16"
>
> Hence, don't request io address range from Davinci MDIO driver and
> just remap it.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Cheers,
--Prabhakar Lad

> ---
>  drivers/net/ethernet/ti/davinci_mdio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 98655b4..b13ec82 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> @@ -371,7 +371,7 @@ static int davinci_mdio_probe(struct platform_device *pdev)
>         spin_lock_init(&data->lock);
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       data->regs = devm_ioremap_resource(dev, res);
> +       data->regs = devm_ioremap_nocache(dev, res->start, resource_size(res));
>         if (IS_ERR(data->regs)) {
>                 ret = PTR_ERR(data->regs);
>                 goto bail_out;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html