netdev - Re: [PATCH net-next 0/2] net: Remove iocb argument from sendmsg and recvmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150228.171250.1612351664541183290.davem@davemloft.net>
Date:	Sat, 28 Feb 2015 17:12:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	viro@...IV.linux.org.uk, hch@....de, netdev@...r.kernel.org,
	erik.hugne@...csson.com, jon.maloy@...csson.com
Subject: Re: [PATCH net-next 0/2] net: Remove iocb argument from sendmsg
 and recvmsg

From: Ying Xue <ying.xue@...driver.com>
Date: Fri, 27 Feb 2015 19:06:35 +0800

> Currently there is only one user - TIPC whose sendmsg() instances
> using iocb argument. Meanwhile, there is no user using iocb argument
> in its recvmsg() instance. Therefore, if we eliminate the werid usage
> of iobc argument from TIPC, the iocb argument can be removed from
> all sendmsg() and recvmsg() instances of the whole network stack.
> 
> By the way, as patch #2 is very big, I can divide it into smaller
> patches regarding module in next version if necessary.
> 
> Reference:
> https://patchwork.ozlabs.org/patch/433960/

You didn't even properly compile test this patch series:

net/dccp/proto.c:744:5: error: conflicting types for ‘dccp_sendmsg’
 int dccp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
     ^
In file included from net/dccp/proto.c:37:0:
net/dccp/dccp.h:313:5: note: previous declaration of ‘dccp_sendmsg’ was here
 int dccp_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
     ^
 ...
net/dccp/proto.c:808:5: error: conflicting types for ‘dccp_recvmsg’
 int dccp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int nonblock,
     ^
In file included from net/dccp/proto.c:37:0:
net/dccp/dccp.h:315:5: note: previous declaration of ‘dccp_recvmsg’ was here
 int dccp_recvmsg(struct kiocb *iocb, struct sock *sk,
     ^