netdev - Re: [Patch net] netns: avoid allocating idr when dumping info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUx69wuHyTY-L6eAhNzuCWxhVd-jSHcKXq7cW4NXBZpOQ@mail.gmail.com>
Date:	Fri, 27 Feb 2015 16:48:20 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net] netns: avoid allocating idr when dumping info

On Fri, Feb 27, 2015 at 10:04 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2015-02-27 at 09:28 -0800, Cong Wang wrote:
>
>> I don't understand why you think this is over engineering,
>> clearly it is normal to allocate resources in newlink rather than
>> dumping. Look at other resources we allocate in newlink.
>
> This has nothing to do with the splat you gave.


Why not? If we from the beginning can avoid allocate any
memory in dumping, such rcu warning would not even trigger.

>
> If you believe there is a _different_ bug, then submit another patch.

I am not 100% sure it is a bug yet, but it does signal some bad sign.

>
> But claiming your patch solves the rcu thing is misleading,
> you gave already 2 wrong patches, trying to hide the real fix.
>

If rcu read lock were the only problem, I wouldn't even want to
reply, too trivial to worthy a reply.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html