netdev - Re: [PATCH kernel 4/4] sh_eth: Fix DMA-API usage for RX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1425092769.4444.102.camel@xylophone.i.decadent.org.uk>
Date:	Sat, 28 Feb 2015 03:06:09 +0000
From:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	"David S.Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...ts.codethink.co.uk,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>,
	Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>,
	Hisashi Nakamura <hisashi.nakamura.ak@...esas.com>,
	Yoshihiro Kaneko <ykaneko0929@...il.com>
Subject: Re: [PATCH kernel 4/4] sh_eth: Fix DMA-API usage for RX buffers

On Fri, 2015-02-27 at 23:36 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 01/27/2015 03:50 AM, Ben Hutchings wrote:
> 
> > - Use the return value of dma_map_single(), rather than calling
> >    virt_to_page() separately
> > - Check for mapping failue
> > - Call dma_unmap_single() rather than dma_sync_single_for_cpu()
> 
> > Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> 
>     I wonder whether you're aware at the previous Renesas' attemept at fixing 
> DMA issues:
> 
> http://marc.info/?t=141586251000003

No, I only started looking at R-Car stuff in December.

>     It was turned down because they tried to deal with several issues in one 
> patch, and they have failed to follow up. Could you look at the rest of the 
> DMA issues reported (and not reported) in that patch?

Issue 1 should be fixed by "sh_eth: Check for DMA mapping errors on
transmit" and this one.

I don't think that issue 2 still applies but I also don't see how it was
fixed, so maybe I'm missing something.

Issue 3 should have been fixed by "sh_eth: Fix padding of short frames
on TX" except that I used the wrong padding function, so it also needs
"sh_eth: Really fix padding of short frames on TX".

Issue 4 should be fixed by this one.  Except that I forgot to add
unmapping in sh_eth_ring_free(), so RX DMA mappings are still leaked
when the device is taken down.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html