lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1425109054.5130.77.camel@edumazet-glaptop2.roam.corp.google.com> Date: Fri, 27 Feb 2015 23:37:34 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Tom Herbert <therbert@...gle.com> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH net-next 3/6] flow_dissector: Add hash_extra field to flow_keys struct On Fri, 2015-02-27 at 19:11 -0800, Tom Herbert wrote: > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index c605d30..d41a034 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -252,7 +252,7 @@ struct qdisc_skb_cb { > unsigned int pkt_len; > u16 slave_dev_queue_mapping; > u16 _pad; > -#define QDISC_CB_PRIV_LEN 20 > +#define QDISC_CB_PRIV_LEN 24 > unsigned char data[QDISC_CB_PRIV_LEN]; > }; > This change breaks kernel build : We already are at the cb[] limit. Please check commit 257117862634d89de33fec74858b1a0ba5ab444b ("net: sched: shrink struct qdisc_skb_cb to 28 bytes") from drivers/infiniband/ulp/ipoib/ipoib_main.c:35: In function ‘ipoib_skb_cb’, inlined from ‘ipoib_hard_header’ at drivers/infiniband/ulp/ipoib/ipoib_main.c:816:19: include/linux/compiler.h:424:20: error: call to ‘__compiletime_assert_136’ declared with attribute error: BUILD_BUG_ON failed: sizeof(skb->cb) < sizeof(struct ipoib_cb) prefix ## suffix(); \ ^ include/linux/compiler.h:429:2: note: in expansion of macro ‘__compiletime_assert’ __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler.h:441:2: note: in expansion of macro ‘_compiletime_assert’ _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/bug.h:50:37: note: in expansion of macro ‘compiletime_assert’ #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ include/linux/bug.h:74:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^ drivers/infiniband/ulp/ipoib/ipoib.h:136:2: note: in expansion of macro ‘BUILD_BUG_ON’ BUILD_BUG_ON(sizeof(skb->cb) < sizeof(struct ipoib_cb)); ^ CC drivers/parport/ieee1284.o CC drivers/net/arcnet/arc-rawmode.o CC drivers/misc/c2port/core.o CC drivers/mfd/rtsx_pcr.o In function ‘ipoib_skb_cb’, inlined from ‘ipoib_start_xmit’ at drivers/infiniband/ulp/ipoib/ipoib_main.c:719:19: include/linux/compiler.h:424:20: error: call to ‘__compiletime_assert_136’ declared with attribute error: BUILD_BUG_ON failed: sizeof(skb->cb) < sizeof(struct ipoib_cb) prefix ## suffix(); \ ^ include/linux/compiler.h:429:2: note: in expansion of macro ‘__compiletime_assert’ __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler.h:441:2: note: in expansion of macro ‘_compiletime_assert’ _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/bug.h:50:37: note: in expansion of macro ‘compiletime_assert’ #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ include/linux/bug.h:74:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^ drivers/infiniband/ulp/ipoib/ipoib.h:136:2: note: in expansion of macro ‘BUILD_BUG_ON’ BUILD_BUG_ON(sizeof(skb->cb) < sizeof(struct ipoib_cb)); ^ make[4]: *** [drivers/infiniband/ulp/ipoib/ipoib_main.o] Error 1 make[3]: *** [drivers/infiniband/ulp/ipoib] Error 2 make[2]: *** [drivers/infiniband/ulp] Error 2 make[1]: *** [drivers/infiniband] Error 2 make[1]: *** Waiting for unfinished jobs.... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists