netdev - Re: [patch -mainline] niu: fix error handling in niu_class_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150228.125940.2141368511096709635.davem@davemloft.net>
Date:	Sat, 28 Feb 2015 12:59:40 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	benoit.taine@...6.fr, fabf@...net.be, bhelgaas@...gle.com,
	edumazet@...gle.com, alexander.h.duyck@...hat.com,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch -mainline] niu: fix error handling in
 niu_class_to_ethflow()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 26 Feb 2015 19:56:56 +0300

> There is a discrepancy here because the niu_class_to_ethflow() returns
> zero on failure and one on success but the caller expected zero on
> success and negative on failure.
> 
> The problem means that we allow the user to pass classes and flow_types
> which we don't want.  I've looked at it a bit and I don't see it as a
> very serious bug.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html