lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 01 Mar 2015 20:24:06 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	netdev@...r.kernel.org, Amir Vadai <amirv@...lanox.com>,
	Tal Alon <talal@...lanox.com>, Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net 2/2] net/mlx4_en: Disbale GRO for incoming loopback/selftest
 packets

Hello.

On 3/1/2015 5:56 PM, Or Gerlitz wrote:

> From: Ido Shamay <idos@...lanox.com>

> Packets which are sent from the selftest (ethtool) flow, should not
> be passed to the GRO stack but rather dropped by the driver after validation.
> To achieve that, we disable GRO for the duration of the selftest.

> Fixes: dd65beac48a5 ("net/mlx4_en: Extend usage of napi_gro_frags")
> Reported-by: Carol Soto <clsoto@...ux.vnet.ibm.com>
> Signed-off-by: Ido Shamay <idos@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_selftest.c |    8 +++++++-
>   1 files changed, 7 insertions(+), 1 deletions(-)

> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
> index 2d8ee66..ac8870c 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
> @@ -81,12 +81,14 @@ static int mlx4_en_test_loopback(struct mlx4_en_priv *priv)
>   {
>   	u32 loopback_ok = 0;
>   	int i;
> -
> +	bool gro_enabled;
>
>           priv->loopback_ok = 0;
>   	priv->validate_loopback = 1;
> +	gro_enabled = (priv->dev->features & NETIF_F_GRO);

    Parens not necessary here.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists