netdev - Re: [PATCH net-next 2/4] net: add IPv4 routing FIB support for switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150302.132015.1646795699731313510.davem@davemloft.net>
Date:	Mon, 02 Mar 2015 13:20:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 2/4] net: add IPv4 routing FIB support for
 switchdev

From: sfeldma@...il.com
Date: Mon,  2 Mar 2015 01:29:13 -0800

> +	dev = netdev_switch_get_by_fib_dev(fi->fib_dev);
 ...
> +	dev = netdev_switch_get_by_fib_dev(fi->fib_dev);

I really should get rid of the fib_dev define, it's always trouble.

Routes can have multiple next hops, and when that is the case you
cannot offload them to hardware in your initial implementation here.

Next hops need to be iterated upon, and that currently can't be
modelled with your abstration right now.

I also don't see you testing properly for
net->ipv4.fib_has_custom_rules,

Oh, I see, that happens in patch #4.  Please make that logic present
from the very beginning.

If you see a multi-nexthop route, for this initial implementation,
you will need to uninstall all routes from the hardware.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html