netdev - Re: [RFC 3/4] sparc: remove __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150302.150405.2072800922470200977.davem@davemloft.net>
Date:	Mon, 02 Mar 2015 15:04:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mhocko@...e.cz
Cc:	linux-mm@...ck.org, akpm@...ux-foundation.org, hannes@...xchg.org,
	rientjes@...gle.com, david@...morbit.com, tytso@....edu,
	mgorman@...e.de, penguin-kernel@...ove.SAKURA.ne.jp,
	sparclinux@...r.kernel.org, vipul@...lsio.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 3/4] sparc: remove __GFP_NOFAIL reuquirement

From: Michal Hocko <mhocko@...e.cz>
Date: Mon,  2 Mar 2015 14:54:42 +0100

> mdesc_kmalloc is currently requiring __GFP_NOFAIL allocation although it
> seems that the allocation failure is handled by all callers (via
> mdesc_alloc). __GFP_NOFAIL is a strong liability for the memory
> allocator and so the users are discouraged to use the flag unless the
> allocation failure is really a nogo. Drop the flag here as this doesn't
> seem to be the case.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.cz>

It is a serious failure.

If we miss an MDESC update due to this allocation failure, the update
is not an event which gets retransmitted so we will lose the updated
machine description forever.

We really need this allocation to succeed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html