netdev - Re: [PATCH net-next 2/4] net: add IPv4 routing FIB support for switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150302.173452.95760557580052043.davem@davemloft.net>
Date:	Mon, 02 Mar 2015 17:34:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 2/4] net: add IPv4 routing FIB support for
 switchdev

From: Scott Feldman <sfeldma@...il.com>
Date: Mon, 2 Mar 2015 14:28:55 -0800

> On Mon, Mar 2, 2015 at 10:20 AM, David Miller <davem@...emloft.net> wrote:
>> If you see a multi-nexthop route, for this initial implementation,
>> you will need to uninstall all routes from the hardware.
> 
> I don't follow that?  In this initial implementation, rocker rejects
> ECMP routes, returning -EOPNTOSUPP, but the route is still installed
> in the kernel.  I'm not seeing why we'd need to uninstall from hw all
> the single-path routes.

I think we need to clear up what -EOPNOTSUPP actually means.

Your FIB layer logic is fine _iff_ a driver always returns -EOPNOTSUPP
for any and all routes ("I can't support hw offloading no matter
what").

With that exact behavior it is valid to only install into the software
tables when that error code is seen.

But if your make -EOPNOTSUPP get returned for some routes and not for
others, then you have to clear the hw devices tables completely before
you can legally proceed to successfully install into the software
tables.

We have to avoid, in any and all cases, any potential situation where
we can have some entries programmed into the hardware and some not.

It's either all or nothing in this initial implementation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html