netdev - Re: [PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54F470AF.6050401@cogentembedded.com>
Date:	Mon, 02 Mar 2015 17:16:15 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jan Kasprzak <kas@...muni.cz>
CC:	Ameen Ali <ameenali023@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

Hello.

On 3/2/2015 4:06 PM, Jan Kasprzak wrote:

> : >avoid out-of-bounds-read by checking count before indexing.
> :
> : >Signed-off-by: Ameen Ali <Ameenali023@...il.com>
> : >---
> : >  drivers/net/wan/cosa.c | 2 +-
> : >  1 file changed, 1 insertion(+), 1 deletion(-)
> :
> : >diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
> : >index 83c39e2..5252e21 100644
> : >--- a/drivers/net/wan/cosa.c
> : >+++ b/drivers/net/wan/cosa.c
> : >@@ -376,7 +376,7 @@ static int __init cosa_init(void)
> : >  	}
> : >  	for (i=0; i<MAX_CARDS; i++)
> : >  		cosa_cards[i].num = -1;
> : >-	for (i=0; io[i] != 0 && i < MAX_CARDS; i++)
> : >+	for (i=0; (i < MAX_CARDS) && (io[i] != 0) ; i++)

> :    Parens you've added aren't necessary.

> 	Yes, but I am OK with both variants.

    Anyway, space before ; should be removed (just noticed).

> :    I suggest to add spaces after and before = in the first expression.

> 	In that case, also the upper for() cycle should be modified
> to match this. I don't think this is necessary.

    As long as it doesn't cause complaints from scripts/checkpatch.pl...

> -Yenya

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html