lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Mar 2015 06:18:02 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Nicolas Schichan <nschichan@...ebox.fr> Cc: "David S. Miller" <davem@...emloft.net>, Tobias Klauser <tklauser@...tanz.ch>, Felipe Balbi <balbi@...com>, Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>, "Eric W. Biederman" <ebiederm@...ssion.com>, Alexander Duyck <alexander.h.duyck@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] bcm63xx_enet: fix poll callback. On Tue, 2015-03-03 at 14:53 +0100, Nicolas Schichan wrote: > On 03/03/2015 02:42 PM, Eric Dumazet wrote: > >> To avoid that, I would take priv->tx_lock only once, or add a limit on > >> the number of skbs that can be drained per round. > > > > Something like this (untested) patch > > I'm not against testing this patch, but we do not have any SMP capable bcm63xx > board here so I don't think it will be of any use. > > bcm6358 and bcm6368 do indeed have two MIPS threads, but SMP is not possible > (due to a data cache or TLB shared across all MIPS threads , unbearably > complicating things, IIRC). > > bcm63xx ARM SoCs look like they can support SMP though. > > Regards, > I am reasonably confident the patch is OK, but I cannot easily compile it on my laptop (x86_64) : CC drivers/net/ethernet/broadcom/bcm63xx_enet.o drivers/net/ethernet/broadcom/bcm63xx_enet.c:34:30: fatal error: bcm63xx_dev_enet.h: No such file or directory #include <bcm63xx_dev_enet.h> ^ compilation terminated. make[1]: *** [drivers/net/ethernet/broadcom/bcm63xx_enet.o] Error 1 make: *** [drivers/net/ethernet/broadcom/bcm63xx_enet.o] Error 2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists