netdev - Re: [PATCH] SUNRPC: use jiffies_to_msecs for converting jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 10:18:22 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Trond Myklebust <trond.myklebust@...marydata.com>,
	Anna Schumaker <anna.schumaker@...app.com>,
	"David S. Miller" <davem@...emloft.net>, linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SUNRPC: use jiffies_to_msecs for converting jiffies

I'll assume Trond or Anna gets this one.--b.

On Tue, Mar 03, 2015 at 04:24:25AM -0500, Nicholas Mc Guire wrote:
> Use jiffies_to_msecs for converting jiffies as it handles all of the corner
> cases reliably and also helps readability.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> This was only compile tested for x86_64_defconfig (implies CONFIG_SUNRPC=y)
> 
> Patch is against 4.0-rc1 (localversion-next is -next-20150303)
> 
>  net/sunrpc/sched.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
> index b91fd9c..c234e7f 100644
> --- a/net/sunrpc/sched.c
> +++ b/net/sunrpc/sched.c
> @@ -90,7 +90,7 @@ __rpc_add_timer(struct rpc_wait_queue *queue, struct rpc_task *task)
>  		return;
>  
>  	dprintk("RPC: %5u setting alarm for %lu ms\n",
> -			task->tk_pid, task->tk_timeout * 1000 / HZ);
> +			task->tk_pid, jiffies_to_msecs(task->tk_timeout));
>  
>  	task->u.tk_wait.expires = jiffies + task->tk_timeout;
>  	if (list_empty(&queue->timer_list.list) || time_before(task->u.tk_wait.expires, queue->timer_list.expires))
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html