netdev - Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 14:58:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr
 CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

From: Joe Perches <joe@...ches.com>
Date: Tue, 03 Mar 2015 11:41:09 -0800

> Until such time as the linux crosstools compilers are updated,
> (they seem stuck on 4.6.3 from 3 years ago)
> https://www.kernel.org/pub/tools/crosstool/
> I think the series is a trivial, small improvement.

You are even admitting that even for your specific case you are
using 3+ year old compiler technology.

These are slow paths, so correctness is the most important aspect.

Converting these locations to consistently use eth_*() is fine,
but then "optimizing" a 6 by memset for configuration paths when
the compiler should be more than capable of doing this just fine
is not convincing at all to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html