netdev - Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 12:40:16 -0800
From:	Joe Stringer <joestringer@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	Pravin Shelar <pshelar@...ira.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jarno Rajahalme <jrajahalme@...ira.com>
Subject: Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

On 3 March 2015 at 12:38, Joe Stringer <joestringer@...ira.com> wrote:
> On 3 March 2015 at 11:39, David Miller <davem@...emloft.net> wrote:
>> From: Joe Stringer <joestringer@...ira.com>
>> Date: Mon,  2 Mar 2015 18:49:56 -0800
>>
>>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
>>> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions
>>> back to regular set actions, the inner attribute length was not changed,
>>> ie, double the length being serialized. This patch fixes the bug.
>>>
>>> Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.")
>>> Signed-off-by: Joe Stringer <joestringer@...ira.com>
>>> ---
>>> This fix needs to be applied to net as well; it applies cleanly.
>>
>> This is backwards, don't do this.  Just say that 'net' needs the fix
>> and submit it targetting that tree only.  Things in 'net' propagate
>> into 'net-next' automatically as I do merges over time, but the
>> opposite is not true.
>
> OK, I'll resend.

Nevermind, I see that you picked it up anyway. Thanks, I'll send fixes
to the appropriate branch in future.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html