netdev - Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 13:04:40 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	gregory.v.rose@...el.com, netdev@...r.kernel.org,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs

On Tue, 2015-03-03 at 15:45 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Tue,  3 Mar 2015 12:38:55 -0800
> 
> > From: Greg Rose <gregory.v.rose@...el.com>
> > 
> > Module dependencies are broken in the case where CONFIG_I40E=y and
> > CONFIG_CONFIGFS_FS=m.  This fixes the broken dependency.
> > 
> > Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> This doesn't fix anything, nothing tests I40E_CONFIGFS_FS:
> 
> [davem@...aco net-next]$ make -s -j8
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> kernel/Makefile:133: *** No X.509 certificates found ***
> kernel/Makefile:133: *** No X.509 certificates found ***
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192df1): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192e25): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
> make: *** [vmlinux] Error 1
> [davem@...aco net-next]$ git am --signoff diff
> Applying: i40e: Fix dependencies in the i40e driver on configfs
> [davem@...aco net-next]$ make oldconfig
> scripts/kconfig/conf --oldconfig Kconfig
> #
> # configuration written to .config
> #
> [davem@...aco net-next]$ make -s -j8
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> kernel/Makefile:133: *** No X.509 certificates found ***
> kernel/Makefile:133: *** No X.509 certificates found ***
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192df1): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192e25): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
> make: *** [vmlinux] Error 1
> [davem@...aco net-next]$ 

Sorry it appears there were two issues that we needed to resolve.  The
first was the issue found with a randonconfig build where if the i40e
was compiled into the kernel and configfs was module, which this was
trying to correct.

The checks in the driver need to be changed from CONFIG_CONFIGFS_FS to
checking for CONFIG_I40E_CONFIGFS_FS, now that there is a Kconfig
option.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)