[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 03 Mar 2015 12:18:29 +0100
From: Nicolas Schichan <nschichan@...ebox.fr>
To: David Miller <davem@...emloft.net>
CC: tklauser@...tanz.ch, balbi@...com,
w-lkml@...enslange-mailadresse.de, ebiederm@...ssion.com,
alexander.h.duyck@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: fix poll callback.
On 03/03/2015 04:15 AM, David Miller wrote:
> First, no signoff, that is required for your patch.
Hello David,
I realized that I had forgotten the signoff-by line too late unfortunately.
> Secondly, we strongly recommend that TX buffer reclaim be not
> accounted at all in the poll budget.
>
> Just do all of the TX work, unconditionally, every time the poll
> routine is invoked. Do not add it into the work variable that
> gets compared against the budget. Pretend it took '0' units of
> work.
I took inspiration from the mv643xx_eth driver which seems to account the tx
buffer reclaim in the work done in its poll callback. I'll send an updated patch.
Thanks,
--
Nicolas Schichan
Freebox SAS
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists