netdev - Re: [PATCH v2] net: ping: Return EAFNOSUPPORT when appropriate.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150304.154723.1071370525446900440.davem@davemloft.net>
Date:	Wed, 04 Mar 2015 15:47:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lorenzo@...gle.com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH v2] net: ping: Return EAFNOSUPPORT when appropriate.

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Tue,  3 Mar 2015 23:16:16 +0900

> 1. For an IPv4 ping socket, ping_check_bind_addr does not check
>    the family of the socket address that's passed in. Instead,
>    make it behave like inet_bind, which enforces either that the
>    address family is AF_INET, or that the family is AF_UNSPEC and
>    the address is 0.0.0.0.
> 2. For an IPv6 ping socket, ping_check_bind_addr returns EINVAL
>    if the socket family is not AF_INET6. Return EAFNOSUPPORT
>    instead, for consistency with inet6_bind.
> 3. Make ping_v4_sendmsg and ping_v6_sendmsg return EAFNOSUPPORT
>    instead of EINVAL if an incorrect socket address structure is
>    passed in.
> 4. Make IPv6 ping sockets be IPv6-only. The code does not support
>    IPv4, and it cannot easily be made to support IPv4 because
>    the protocol numbers for ICMP and ICMPv6 are different. This
>    makes connect(::ffff:192.0.2.1) fail with EAFNOSUPPORT instead
>    of making the socket unusable.
> 
> Among other things, this fixes an oops that can be triggered by:
> 
>     int s = socket(AF_INET, SOCK_DGRAM, IPPROTO_ICMP);
>     struct sockaddr_in6 sin6 = {
>         .sin6_family = AF_INET6,
>         .sin6_addr = in6addr_any,
>     };
>     bind(s, (struct sockaddr *) &sin6, sizeof(sin6));
> 
> Change-Id: If06ca86d9f1e4593c0d6df174caca3487c57a241
> Signed-off-by: Lorenzo Colitti <lorenzo@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html