netdev - Re: [patch net] team: don't traverse port list using rcu in team_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150304.160200.1361747224026478715.davem@davemloft.net>
Date:	Wed, 04 Mar 2015 16:02:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org
Subject: Re: [patch net] team: don't traverse port list using rcu in
 team_set_mac_address

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed,  4 Mar 2015 08:36:31 +0100

> Currently the list is traversed using rcu variant. That is not correct
> since dev_set_mac_address can be called which eventually calls
> rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this
> by remove the rcu usage here.
> 
> Fixes: 3d249d4ca7 "net: introduce ethernet teaming device"
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html