netdev - Re: [PATCH net-next 0/2] Neighbour table prep for MPLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150304.002502.1950561993507910047.davem@davemloft.net>
Date:	Wed, 04 Mar 2015 00:25:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] Neighbour table prep for MPLS

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Tue, 03 Mar 2015 17:09:35 -0600

> In preparation for using the IPv4 and IPv6 neighbour tables in my mpls
> code this patchset factors out ___neigh_lookup_noref from
> __ipv4_neigh_lookup_noref, __ipv6_lookup_noref and neigh_lookup.
> Allowing the lookup logic to be shared between the different
> implementations.  At what appears to be no cost. (Aka the same assembly
> is generated for ip6_finish_output2 and ip_finish_output2).
> 
> After that I add a simple function that takes an address family and an
> address consults the neighbour table and sends the packet to the
> appropriate location.  The address family argument decoupls callers
> of neigh_xmit from the addresses families the packets are sent over.
> (Aka The ipv6 module can be loaded after mpls and a previously
> configured ipv6 next hop will start working).
> 
> The refactoring in ___neigh_lookup_noref may be a bit overkill but it
> feels like the right thing to do.  Especially since the same code is
> generated.

Series applied, thanks.

Maybe we can make neigh_table_find() faster by making it a direct
array demux of some kind instead of some switch statment thing?
It's the only think I don't like about neigh_xmit().

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html