netdev - Re: [net-next PATCH 2/2] igb: Make arrays on stack static const to avoid reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1425583635.2556.143.camel@jtkirshe-mobl>
Date:	Thu, 05 Mar 2015 11:27:15 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [net-next PATCH 2/2] igb: Make arrays on stack static const to
 avoid reallocation

On Thu, 2015-03-05 at 11:25 -0800, Alexander Duyck wrote:
> While addressing the pin problem I noticed that all of the pin
> register
> values where having to be pushed onto the stack each time the function
> was
> called.  To avoid that I am making them static const so that they
> should
> only need to be allocated once and we can avoid all the instructions
> to get
> them onto the stack..
> 
> size before:
>    text    data     bss     dec     hex filename
>  161477   10512       8  171997
> 29fdd drivers/net/ethernet/intel/igb/igb.ko
> 
> size after:
>    text    data     bss     dec     hex filename
>  161205   10512       8  171725
> 29ecd drivers/net/ethernet/intel/igb/igb.ko
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c |   24
> ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Thanks Alex, I have added your patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)