netdev - Re: [PATCH net-next] tg3: use napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425595653.15992.3.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Thu, 5 Mar 2015 14:47:33 -0800
From:	Michael Chan <mchan@...adcom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Prashant Sreedharan <prashant@...adcom.com>
Subject: Re: [PATCH net-next] tg3: use napi_complete_done()

On Thu, 2015-03-05 at 10:41 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> Using napi_complete_done() instead of napi_complete() allows
> us to use /sys/class/net/ethX/gro_flush_timeout
> 
> GRO layer can aggregate more packets if the flush is delayed a bit,
> without having to set too big coalescing parameters that impact
> latencies.
> 
There is another napi_complete() call when we detect tx errors.  I guess
we can leave that one unconverted as that code path is very rare.
Thanks.

Acked-by: Michael Chan <mchan@...adcom.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html