netdev - Re: [PATCH net-next] rocker: check for BRIDGE_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150305083621.GC2033@nanopsycho.orion>
Date:	Thu, 5 Mar 2015 09:36:21 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	roopa@...ulusnetworks.com
Cc:	sfeldma@...il.com, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] rocker: check for BRIDGE_FLAGS_SELF in bridge
 setlink handler

Wed, Mar 04, 2015 at 01:15:29AM CET, roopa@...ulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
>With the recent addition of the NETIF_F_HW_SWITCH_OFFLOAD flag
>on rocker ports, the second command (bridge link set) below will turn off
>learning in the rocker hw (Scott/Jiri, need some confirmation from
>you that this is indeed a problem and if the below patch is ok).
>
>ip link set dev swp1 master br0
>bridge link set dev swp1 learning off master
>bridge link set dev swp1 learning_sync on self
>
>This patch fixes rocker to ignore learning setting when 'master'
>is set. This makes it possible to set/unset learning in kernel and bridge
>driver independently.
>
>The below command will continue to set learning on in both kernel and rocker
>hw:
>bridge link set dev swp1 learning on
>
>Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
>---
> drivers/net/ethernet/rocker/rocker.c |    3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>index e5a15a4..d7c31d2 100644
>--- a/drivers/net/ethernet/rocker/rocker.c
>+++ b/drivers/net/ethernet/rocker/rocker.c
>@@ -3769,6 +3769,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev,
> 	struct nlattr *attr;
> 	int err;
> 
>+	if (flags && !(flags & BRIDGE_FLAGS_SELF))
>+		return 0;
>+

I think that the called should handle this case, not every particular
driver. How about to put this into rtnl_bridge_setlink?


> 	protinfo = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg),
> 				   IFLA_PROTINFO);
> 	if (protinfo) {
>-- 
>1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html