netdev - Re: [PATCH v5 2/4] gpiolib: add gpiod_get_array and gpiod_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 Mar 2015 12:52:43 +0100
From:	Rojhalat Ibrahim <imr@...chenk.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 2/4] gpiolib: add gpiod_get_array and gpiod_put_array functions

On Thursday 05 March 2015 09:55:09 Linus Walleij wrote:
> On Wed, Feb 11, 2015 at 5:27 PM, Rojhalat Ibrahim <imr@...chenk.de> wrote:
> 
> > Introduce new functions for conveniently obtaining and disposing of an entire
> > array of GPIOs with one function call.
> >
> > Suggested-by: Alexandre Courbot <acourbot@...dia.com>
> > Signed-off-by: Rojhalat Ibrahim <imr@...chenk.de>
> > Reviewed-by: Alexandre Courbot <acourbot@...dia.com>
> >
> > ACPI part:
> > Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> >
> > DT part:
> > Tested-by: Rojhalat Ibrahim <imr@...chenk.de>
> > ---
> > Change log:
> >   v5: move the ACPI functions to gpiolib-acpi.c
> >   v4: - use shorter names for members of struct gpio_descs
> >       - rename lut_gpio_count to platform_gpio_count for clarity
> >       - add check for successful memory allocation
> >       - use ERR_CAST()
> >   v3: - rebase on current linux-gpio devel branch
> >       - fix ACPI GPIO counting
> >       - allow for zero-sized arrays
> >       - make the flags argument mandatory for the new functions
> >       - clarify documentation
> >   v2: change interface
> 
> Patch applied with some fuzzing, check that it ended up correctly
> in my git (or linux-next).
> 

Looks good to me.

Thanks.
   Rojhalat

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html