netdev - Re: [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F9DA71.804@atmel.com>
Date:	Fri, 6 Mar 2015 17:48:49 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	<monstr@...str.eu>, Michal Simek <michal.simek@...inx.com>,
	<linux-kernel@...r.kernel.org>
CC:	Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] net: macb: Include multi queue support for xilinx
 ZynqMP ethernet version

Le 05/03/2015 15:00, Michal Simek a écrit :
> Hi Nicolas,
> 
> On 03/05/2015 02:04 PM, Michal Simek wrote:
>> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>
>>
>> Include multi queue support for the ethernet IP version in xilinx ZynqMP
>> SoC.
>>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@...inx.com>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> ---
>>
>>  drivers/net/ethernet/cadence/macb.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index ad76b8e35a00..24b1eb466e52 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -2192,7 +2192,7 @@ static void macb_probe_queues(void __iomem *mem,
>>  
>>  	/* is it macb or gem ? */
>>  	mid = __raw_readl(mem + MACB_MID);
>> -	if (MACB_BFEXT(IDNUM, mid) != 0x2)
>> +	if (MACB_BFEXT(IDNUM, mid) < 0x2)
>>  		return;
>>  
>>  	/* bit 0 is never set but queue 0 always exists */
>>
> 
> Can you please check this?
> (There will be definitely v2 because I forget to base it on net-next).

Michal,

It seems correct to me: you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html