netdev - Re: [PATCH net] net: bcmgenet: properly disable password matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150305.211619.2253898945917128435.davem@davemloft.net>
Date:	Thu, 05 Mar 2015 21:16:19 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: properly disable password matching

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed,  4 Mar 2015 11:43:03 -0800

> bcmgenet_set_wol() correctly sets MPD_PW_EN when a password is specified
> to match magic packets against, however, when we switch from a
> password-matching to a matching without password we would leave this bit
> turned on, and GENET would only match magic packets with passwords.
> 
> This can be reproduced using the following sequence:
> 
> ethtool -s eth0 wol g
> ethtool -s eth0 wol s sopass 00:11:22:33:44:55
> ethtool -s eth0 wol g
> 
> The simple fix is to clear the MPD_PWD_EN bit when WAKE_MAGICSECURE is
> not set.
> 
> Fixes: c51de7f3976b ("net: bcmgenet: add Wake-on-LAN support code")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html