netdev - Re: [PATCH net-next] fib: make netdev_switch_fib_ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bAASmi+VxbzJ8CKkDpwdtU73HFaDAhyYxd3wDfhmsmqSQ@mail.gmail.com>
Date:	Fri, 6 Mar 2015 12:31:56 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header
 file static inline

On Fri, Mar 6, 2015 at 8:44 AM, Willem de Bruijn <willemb@...gle.com> wrote:
> From: Willem de Bruijn <willemb@...gle.com>
>
> When building without CONFIG_NET_SWITCHDEV,
> netdev_switch_fib_ipv4_abort is defined in the header file. It must
> be static inline to avoid build failure at link time.
>
> Fixes: 8e05fd7166c6 ("fib: hook IPv4 fib for hardware offload")
>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> ---
>  include/net/switchdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index dc0a5cc..933fac4 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -129,7 +129,7 @@ static inline int netdev_switch_fib_ipv4_del(u32 dst, int dst_len,
>         return 0;
>  }
>
> -void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
> +static inline void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
>  {
>  }


Acked-by: Scott Feldman <sfeldma@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html