netdev - Re: [PATCH net-next] inet_diag: remove duplicate code from inet_twsk_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150305.225518.263646702699262144.davem@davemloft.net>
Date:	Thu, 05 Mar 2015 22:55:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] inet_diag: remove duplicate code from
 inet_twsk_diag_dump()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 05 Mar 2015 10:18:14 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> timewait sockets now share a common base with established sockets.
> 
> inet_twsk_diag_dump() can use inet_diag_bc_sk() instead of duplicating
> code, granted that inet_diag_bc_sk() does proper userlocks
> initialization.
> 
> twsk_build_assert() will catch any future changes that could break
> the assumptions.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

This looks fine, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html