netdev - Re: [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150306061347.GA3311@secunet.com>
Date:	Fri, 6 Mar 2015 07:13:47 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...el.com>
CC:	<herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <fengyuleidian0615@...il.com>
Subject: Re: [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm
 netlink msg on 64bits host

On Tue, Jan 27, 2015 at 05:00:29PM +0800, Fan Du wrote:
> structure like xfrm_usersa_info or xfrm_userpolicy_info
> has different sizeof when compiled as 32bits and 64bits
> due to not appending pack attribute in their definition.
> This will result in broken SA and SP information when user
> trying to configure them through netlink interface.
> 
> Inform user land about this situation instead of keeping
> silent, the upper test scripts would behave accordingly.
> 
> Quotes from: http://marc.info/?l=linux-netdev&m=142226348715503&w=2
> >
> > Before a clean solution show up, I think it's better to warn user in some way
> > like http://patchwork.ozlabs.org/patch/323842/ did. Otherwise, many people
> > who stuck there will always spend time and try to fix this issue in whatever way.
> 
> Yes, this is the first thing we should do. I'm willing to accept a patch
> 
> Signed-off-by: Fan Du <fan.du@...el.com>

Now applied to ipsec-next, thanks a lot Fan!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html