netdev - Re: [PATCH] filter: introduce SKF_AD_VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150306080951.GB2841@morgoth.brq.redhat.com>
Date:	Fri, 6 Mar 2015 09:09:51 +0100
From:	Michal Sekletar <msekleta@...hat.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
	Jiri Pirko <jpirko@...hat.com>, guy@...m.mit.edu,
	atzm@...atosphere.co.jp
Subject: Re: [PATCH] filter: introduce SKF_AD_VLAN_PROTO BPF extension

On Thu, Mar 05, 2015 at 12:40:42PM -0800, Alexei Starovoitov wrote:
> On 3/5/15 12:03 PM, Daniel Borkmann wrote:
> >On 03/05/2015 05:52 PM, Alexei Starovoitov wrote:
> >>imo there is a benefit of giving programs more visibility into
> >>skb metadata.
> >
> >I'm not really a big fan of it, but given we added commit a0cdfcf39362
> >("packet: deliver VLAN TPID to userspace") to packet sockets ...
> 
> good point, since skb->vlan_proto is already exposed to user space
> via that commit, it makes sense to let bpf see it as well.
> For consistency with tpacket, I'd call it SKF_AD_VLAN_TPID

Thanks everyone for taking the time to look into this. I will post v2 soon.
Hopefully addressing all the problems brought up.

Michal

> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html