netdev - Re: [PATCH net-next 1/3] switchdev: fix stp update API to work with layered netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bAHABpfNU9LK7GtKNMZHfdAWwg5u8R7kRH4upKpy2fOsQ@mail.gmail.com>
Date:	Fri, 6 Mar 2015 01:30:43 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	Jiří Pírko <jiri@...nulli.us>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] switchdev: fix stp update API to work with
 layered netdevices

On Thu, Mar 5, 2015 at 8:04 PM,  <roopa@...ulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
> make it same as the netdev_switch_port_bridge_setlink/dellink
> api (ie traverse lowerdevs to get to the switch port).
>
> removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because bridge ports
> can be bonds and teams which might not implement this ndo.
>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  include/net/switchdev.h   |    7 +++++++
>  net/switchdev/switchdev.c |   30 +++++++++++++++++++++++++++++-
>  2 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index cfcdac2..a93279b 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -51,6 +51,7 @@ int ndo_dflt_netdev_switch_port_bridge_dellink(struct net_device *dev,
>                                                struct nlmsghdr *nlh, u16 flags);
>  int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *dev,
>                                                struct nlmsghdr *nlh, u16 flags);
> +int ndo_dflt_netdev_switch_port_stp_update(struct net_device *dev, u8 state);
>  #else
>
>  static inline int netdev_switch_parent_id_get(struct net_device *dev,
> @@ -109,6 +110,12 @@ static inline int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *
>         return 0;
>  }
>
> +static inline int ndo_dflt_netdev_switch_port_stp_update(struct net_device *dev,
> +                                                        u8 state)
> +{
> +       return 0;

Shouldn't this be return -EOPNOTSUPP to be consistent with
netdev_switch_port_stp_update() when CONFIG_NET_SWITCHDEV is not
defined?

The rest looks good, thanks Roopa.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html