netdev - Re: [PATCHv5 net-next 3/4] ipv4: Create probe timer for tcp PMTU as per RFC4821

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1425751373.4027.15.camel@decadent.org.uk>
Date:	Sat, 07 Mar 2015 18:02:53 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Fan Du <fan.du@...el.com>
Cc:	jheffner@....edu, davem@...emloft.net, edumazet@...gle.com,
	netdev@...r.kernel.org, fengyuleidian0615@...il.com
Subject: Re: [PATCHv5 net-next 3/4] ipv4: Create probe timer for tcp PMTU as
 per RFC4821

On Fri, 2015-03-06 at 11:18 +0800, Fan Du wrote:
[...]
> +	/* When misfortune happens, we are reprobing actively,
> +	 * and then reprobe timer has expired. We stick with current
> +	 * probing process by not resetting search range to its orignal.
> +	 */
>  	if (probe_size > tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_high) ||
> -	    interval < max(1, net->ipv4.sysctl_tcp_probe_threshold)) {
> -		/* TODO: set timer for probe_converge_event */
> +		interval < net->ipv4.sysctl_tcp_probe_threshold) {
[...]

Did you mean to remove the max() there?

It might be better to enforce a minimum value when the sysctl is set,
anyway.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)