netdev - Re: [PATCH net-next] vlan: allow changing VLAN id and protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150308144432.02f9c311@urahara>
Date:	Sun, 8 Mar 2015 14:44:32 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jeff Kirsher <tarbal@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vlan: allow changing VLAN id and protocol

On Sun, 08 Mar 2015 11:25:42 -0700
Jeff Kirsher <tarbal@...il.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On 03/08/2015 11:06 AM, Stephen Hemminger wrote:
> > 
> > The VLAN netlink interface allows changing the ID and protocol of an existing
> > VLAN, but it was being ignored. Move the initialization of the proto and
> > id into the change function to fix that.
> > 
> > Example of the problem:
> >   # modprobe dummy
> >   # ip li set dev dummy0 up
> >   # ip li add link dummy0 name dummy0.10 type vlan id 100
> >   # ip li set dummy0.10 type vlan id 111
> >   # ip -d li show dev dummy0.10
> > 19: dummy0.10@...my0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT 
> >     link/ether be:d3:7c:7f:86:18 brd ff:ff:ff:ff:ff:ff
> >     vlan id 100 <REORDER_HDR> 
> >             ^^^ should be 111
> > 
> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Self-NAK

This needs more state work to handle the case of GARP and all the
filtering stuff.  There be small dragons here.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html