netdev - Re: [PATCH net-next 1/6] tcp_metrics: panic when tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FDEB61.6020501@cogentembedded.com>
Date:	Mon, 09 Mar 2015 21:50:09 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	David Miller <davem@...emloft.net>
CC:	edumazet@...gle.com, netdev@...r.kernel.org,
	stephen@...workplumber.org, nicolas.dichtel@...nd.com,
	roopa@...ulusnetworks.com, hannes@...essinduktion.org,
	ddutt@...ulusnetworks.com, vipin@...ulusnetworks.com,
	shmulik.ladkani@...il.com, dsahern@...il.com
Subject: Re: [PATCH net-next 1/6] tcp_metrics: panic when tcp_metrics can
 not be allocated

Hello.

On 3/9/2015 9:27 PM, Eric W. Biederman wrote:

> Panic so that in the unlikely event we have problems we will have a
> clear place to start debugging instead of a mysterious NULL pointer
> deference later on.

> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---
>   net/ipv4/tcp_metrics.c | 1 +
>   1 file changed, 1 insertion(+)

> diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
> index e5f41bd5ec1b..fdf4bdda971f 100644
> --- a/net/ipv4/tcp_metrics.c
> +++ b/net/ipv4/tcp_metrics.c
> @@ -1186,5 +1186,6 @@ cleanup_subsys:
>   	unregister_pernet_subsys(&tcp_net_metrics_ops);
>
>   cleanup:
> +	panic("Could not allocate the tcp_metrics hash table\n");
>   	return;

    You can drop this *return* as well, it serves not purpose.

>   }

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html