netdev - Re: [PATCH net-next] tipc: fix inconsistent signal handling regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150309.154251.1600416012786968737.davem@redhat.com>
Date:	Mon, 09 Mar 2015 15:42:51 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	erik.hugne@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	jon.maloy@...csson.com, ying.xue@...driver.com,
	richard.alpe@...csson.com, laszlo.benedek@...csson.com
Subject: Re: [PATCH net-next] tipc: fix inconsistent signal handling
 regression

From: <erik.hugne@...csson.com>
Date: Mon, 9 Mar 2015 10:43:42 +0100

> From: Erik Hugne <erik.hugne@...csson.com>
> 
> Commit 9bbb4ecc6819 ("tipc: standardize recvmsg routine") changed
> the sleep/wakeup behaviour for sockets entering recv() or accept().
> In this process the order of reporting -EAGAIN/-EINTR was reversed.
> This caused problems with wrong errno being reported back if the
> timeout expires. The same problem happens if the socket is
> nonblocking and recv()/accept() is called when the process have
> pending signals. If there is no pending data read or connections to
> accept, -EINTR will be returned instead of -EAGAIN.
> 
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
> Reviewed-by: Ying Xue <ying.xue@...driver.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
> Reported-by László Benedek <laszlo.benedek@...csson.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html