netdev - Re: [PATCH net 1/1] tipc: fix bug in link failover handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150309.162027.114207740254748981.davem@redhat.com>
Date:	Mon, 09 Mar 2015 16:20:27 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: fix bug in link failover handling

From: Jon Maloy <jon.maloy@...csson.com>
Date: Mon,  9 Mar 2015 16:16:22 -0400

> In commit c637c1035534867b85b78b453c38c495b58e2c5a
> ("tipc: resolve race problem at unicast message reception") we
> introduced a new mechanism for delivering buffers upwards from link
> to socket layer.
> 
> That code contains a bug in how we handle the new link input queue
> during failover. When a link is reset, some of its users may be blocked
> because of congestion, and in order to resolve this, we add any pending
> wakeup pseudo messages to the link's input queue, and deliver them to
> the socket. This misses the case where the other, remaining link also
> may have congested users. Currently, the owner node's reference to the
> remaining link's input queue is unconditionally overwritten by the
> reset link's input queue. This has the effect that wakeup events from
> the remaining link may be unduely delayed (but not lost) for a
> potentially long period.
> 
> We fix this by adding the pending events from the reset link to the
> input queue that is currently referenced by the node, whichever one
> it is.
> 
> This commit should be applied to both net and net-next.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Jon, there is no such thing, ever, as a patch that gets applied to both
'net' and 'net-next'.

The patch is either targetted at 'net' or 'net-next', not both.

If it is targetted at 'net', as a proper bug fix should be, then naturally
it will propagate implicitly to 'net-next' as merges occur.

I'm applying this, but I'm getting kinda tired of explaining this stuff
to people, expecially as it is clearly documented in the netdev FAQ.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html