netdev - Re: [PATCH 4/8] net/socket: sys_accept4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425939066.8261.18.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 09 Mar 2015 15:11:06 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	Maciej Żenczykowski <maze@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Theodore Ts'o <tytso@....edu>, netdev@...r.kernel.org
Subject: Re: [PATCH 4/8] net/socket: sys_accept4 - reverse allocation order

On Mon, 2015-03-09 at 14:19 -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---

Unfortunately this changes accept() behavior when/if ENFILE/EMFILE is
reported.

Some applications might depend on this behavior to eventually start a
garbage collection of a cache using file descriptors to regular files.

After your patch, a failed accept() call would silently 'consume' a
session in the listener queue.

Also, this patch series should be CCed to lkml and Al Viro, as it is a
mix of fs & network changes.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html