netdev - Re: [PATCH net-next 2/2] net: bcmgenet: add support for xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGVrzcba9BEgcxAk3rbAzW137HyEGpoo_wn+8mibAq7yOc=kYA@mail.gmail.com>
Date:	Mon, 9 Mar 2015 15:49:14 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Petri Gynther <pgynther@...gle.com>,
	Jaedon Shin <jaedon.shin@...il.com>
Subject: Re: [PATCH net-next 2/2] net: bcmgenet: add support for xmit_more

2015-03-09 15:36 GMT-07:00 Eric Dumazet <eric.dumazet@...il.com>:
> On Mon, 2015-03-09 at 15:13 -0700, Florian Fainelli wrote:
>
>> bcmgenet_xmit() and bcmgenet_tx_reclaim() are the only two functions
>> that can stop a queue, and they are using a spinlock to avoid that.
>
> It does not matter.
>
> If you hit the condition :
>
> if (ring->free_bds <= (MAX_SKB_FRAGS + 1))
>      netif_tx_stop_queue(txq);
>
> Then maybe you filled the ring buffer with skb having xmit_more set, and
> you never did a bcmgenet_tdma_ring_writel()

Right, thanks for pointing that out.

>
> Look at other drivers using xmit_more, because you have to reverse
> things.
>
> The skeleton is :
>
> maybe_stop_tx();
>
> if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
>     mmiiowb();
>     ...
> }
>

Will fix that, thanks
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html