netdev - Re: [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bAoB4tWt1PYwxdXOubigkatSs2j2Xo5oLiEk48_k5RwBQ@mail.gmail.com>
Date:	Mon, 9 Mar 2015 01:38:05 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	roopa <roopa@...ulusnetworks.com>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jiří Pírko <jiri@...nulli.us>,
	"alexander.h.duyck@...hat.com" <alexander.h.duyck@...hat.com>
Subject: Re: [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops

On Sun, Mar 8, 2015 at 11:22 PM, roopa <roopa@...ulusnetworks.com> wrote:
> On 3/8/15, 3:16 PM, Scott Feldman wrote:
>>
>> On Sun, Mar 8, 2015 at 7:31 AM, roopa <roopa@...ulusnetworks.com> wrote:
>>>
>>> On 3/6/15, 11:59 AM, Scott Feldman wrote:

[cut]

>> Can you show an working example of prepend/append case where
>> programming hardware would be different than the replace case?
>>
>>
> scott, I don't have an example of kernel vs hw right now. But, since we only
> want to know if the switch driver can figure out
> the kernel route ordering in case of append vs replace, below kernel append
> and replace examples
> might help (just pasting it from my notes and may contain unneeded
> information).
>
> Thanks,
> Roopa
>
> append:
>
> =====
>
> #ipv4
>
> ip route show
>
> 10.0.12.2
>
>     nexthop via 10.0.13.2  dev dummy0 weight 1
>
>     nexthop via 10.0.14.2  dev dummy1 weight 1
>
>
> ip route append 10.0.12.2 nexthop via 10.0.15.2 dev dummy2
>
>
> ip monitor route
>
> 10.0.12.2 via 10.0.15.2 dev dummy2
>
>
> # A new route was appended
>
> ip route show
>
> 10.0.12.2
>
>     nexthop via 10.0.13.2  dev dummy0 weight 1
>
>     nexthop via 10.0.14.2  dev dummy1 weight 1
>
> 10.0.12.2 via 10.0.15.2 dev dummy2

I think you're right that append will be different than replace.  And
we'll need to pass in the netlink NLM_F_xxx flags to the API, so the
driver can deal with it.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html