netdev - Re: [Patch net-next] net_sched: destroy proto tp when all filters are gone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150308.222924.1569062248098813848.davem@davemloft.net>
Date:	Sun, 08 Mar 2015 22:29:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, cwang@...pensource.com, jhs@...atatu.com
Subject: Re: [Patch net-next] net_sched: destroy proto tp when all filters
 are gone

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri,  6 Mar 2015 11:47:59 -0800

> From: Cong Wang <cwang@...pensource.com>
> 
> Kernel automatically creates a tp for each
> (kind, protocol, priority) tuple, which has handle 0,
> when we add a new filter, but it still is left there
> after we remove our own, unless we don't specify the
> handle (literally means all the filters under
> the tuple). For example this one is left:
> 
>   # tc filter show dev eth0
>   filter parent 8001: protocol arp pref 49152 basic
> 
> The user-space is hard to clean up these for kernel
> because filters like u32 are organized in a complex way.
> So kernel is responsible to remove it after all filters
> are gone.  Each type of filter has its own way to
> store the filters, so each type has to provide its
> way to check if all filters are gone.
> 
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <cwang@...pensource.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

This looks fine to me, Jamal please review.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html