netdev - Re: [patch net-next 3/4] net: refactor IPv4 and IPv6 fragmentation APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425913658.8261.4.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 09 Mar 2015 08:07:38 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Andy Zhou <azhou@...ira.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [patch net-next 3/4] net: refactor IPv4 and IPv6 fragmentation
 APIs

On Mon, 2015-03-09 at 01:01 -0700, Andy Zhou wrote:

> +int ip_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *))
> +{
> +	struct iphdr *iph;
> +	struct net_device *dev;
> +	unsigned int mtu, ll_rs;
> +	struct rtable *rt = skb_rtable(skb);


For better readability, we prefer to order local variables in decreasing
lengths :

->

+int ip_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *))
+{
+       struct rtable *rt = skb_rtable(skb);
+       unsigned int mtu, ll_rs;
+       struct net_device *dev;
+       struct iphdr *iph;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html