netdev - Re: [PATCH net-next] mpls: Allow mpls_gso and mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y4n4iv4j.fsf@x220.int.ebiederm.org>
Date:	Tue, 10 Mar 2015 13:07:40 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Robert Shearman <rshearma@...cade.com>
Cc:	"davem\@davemloft.net" <davem@...emloft.net>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] mpls: Allow mpls_gso and mpls_router to be built as modules

Robert Shearman <rshearma@...cade.com> writes:

> On 10/03/15 17:17, Eric W. Biederman wrote:
>> Robert Shearman <rshearma@...cade.com> writes:
>>
>>> CONFIG_MPLS=m doesn't result in a kernel module being built because it
>>> applies to the net/mpls directory, rather than to .o files.
>>>
>>> So revert the MPLS menuitem to being a boolean and make MPLS_GSO and
>>> MPLS_ROUTING tristates to allow mpls_gso and mpls_router modules to be
>>> produced as desired.
>>
>> Good catch.  But I am pretty certain this does not result in the mpls
>> routing code in af_mpls being built as a module either.
>
> I'm pretty sure it does ;-)
>
>   CC [M]  net/mpls/af_mpls.o
>   LD [M]  net/mpls/mpls_router.o
>   Building modules, stage 2.
>   MODPOST 3010 modules
>   LD [M]  net/mpls/mpls_router.ko
>
> I deliberately split out the makefile rules so that the would be named
> mpls_router, rather than af_mpls to avoid any potential confusion with
> the mpls_gso module.

Where do the files that go into mpls_router.o come from.

Ah.  I missed the mpls_route := af_mpls.o line.


Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html