netdev - Re: [net-next PATCH] fib_trie: Correctly handle case of key == 0 in leaf_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150310.161426.2237948745314134712.davem@davemloft.net>
Date:	Tue, 10 Mar 2015 16:14:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sd@...asysnail.net
Cc:	alexander.h.duyck@...hat.com, netdev@...r.kernel.org
Subject: Re: [net-next PATCH] fib_trie: Correctly handle case of key == 0
 in leaf_walk_rcu

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Tue, 10 Mar 2015 19:48:39 +0100

> 2015-03-10, 11:25:41 -0700, Alexander Duyck wrote:
>> In the case of a trie that had no tnodes with a key of 0 the initial
>> look-up would fail resulting in an out-of-bounds cindex on the first tnode.
>> This resulted in an entire trie being skipped.
>> 
>> In order resolve this I have updated the cindex logic in the initial
>> look-up so that if the key is zero we will always traverse the child zero
>> path.
>> 
>> Fixes: 8be33e95 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
>> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
>> ---
> 
> Tested-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html