netdev - Re: [PATCH net-next] fib_trie: call fib_table_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FF562B.2060701@redhat.com>
Date:	Tue, 10 Mar 2015 13:38:03 -0700
From:	Alexander Duyck <alexander.h.duyck@...hat.com>
To:	Sabrina Dubroca <sd@...asysnail.net>, davem@...emloft.net
CC:	netdev@...r.kernel.org, sfeldma@...il.com
Subject: Re: [PATCH net-next] fib_trie: call fib_table_flush_external under
 RTNL

On 03/10/2015 01:03 PM, Sabrina Dubroca wrote:
> Move rtnl_lock() before the call to fib4_rules_exit so that
> fib_table_flush_external is called under RTNL.
>
> Fixes: 104616e74e0b ("switchdev: don't support custom ip rules, for now")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---
>   net/ipv4/fib_frontend.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index e067770235bf..ed94bc80eb78 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -1126,11 +1126,12 @@ static void ip_fib_net_exit(struct net *net)
>   {
>   	unsigned int i;
>   
> +	rtnl_lock();
> +
>   #ifdef CONFIG_IP_MULTIPLE_TABLES
>   	fib4_rules_exit(net);
>   #endif
>   
> -	rtnl_lock();
>   	for (i = 0; i < FIB_TABLE_HASHSZ; i++) {
>   		struct hlist_head *head = &net->ipv4.fib_table_hash[i];
>   		struct hlist_node *tmp;

Acked-by: Alexander Duyck <alexander.h.duyck@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html