netdev - Re: [net-next PATCH] fib_trie: Address possible NULL pointer dereference in resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 18:37:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...hat.com
Cc:	netdev@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [net-next PATCH] fib_trie: Address possible NULL pointer
 dereference in resize

From: Alexander Duyck <alexander.h.duyck@...hat.com>
Date: Tue, 10 Mar 2015 14:39:34 -0700

> If the inflate call failed it would return NULL.  As a result tp would be
> set to NULL and cause use to trigger a NULL pointer dereference in
> should_halve if the inflate failed on the first attempt.
> 
> In order to prevent this we should decrement max_work before we actually
> attempt to inflate as this will force us to exit before attempting to halve
> a node we should have inflated.  In order to keep things symmetric between
> inflate and halve I went ahead and also moved the decrement of max_work for
> the halve case as well so we take care of that before we actually attempt
> to halve the tnode.
> 
> Fixes: 88bae714 ("fib_trie: Add key vector to root, return parent key_vector in resize")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>

Applied, thanks Alex.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html