netdev - rtnl_newlink() cleanup on namespace change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150310.184347.1581730121744725414.davem@davemloft.net>
Date:	Tue, 10 Mar 2015 18:43:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	netdev@...r.kernel.org
CC:	xiyou.wangcong@...il.com
Subject: rtnl_newlink() cleanup on namespace change


Cong, I was reviewing commit 7afb8886a05be68e376655539a064ec672de8a8e
("rtnetlink: call ->dellink on failure when ->newlink exists") during
a stable backport and I noticed that the function, after the change
you made, subsequently goes:

		if (link_net) {
			err = dev_change_net_namespace(dev, dest_net, ifname);
			if (err < 0)
				unregister_netdevice(dev);
		}

Isn't the potential ->dellink() unwinding necessary in this path too?

If not, why not?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html