netdev - Re: [PATCH] can: use sock_efree instead of own destructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FF05E4.6060002@hartkopp.net>
Date:	Tue, 10 Mar 2015 15:55:32 +0100
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
	mkl@...gutronix.de,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	Alexander Duyck <alexander.h.duyck@...hat.com>
Subject: Re: [PATCH] can: use sock_efree instead of own destructor

On 03/10/2015 03:36 PM, Eric Dumazet wrote:
> On Tue, 2015-03-10 at 14:36 +0100, Oliver Hartkopp wrote:

>> Maybe Alexander can send a patch which adds a comment, as I don't know if I
>> would find the best words for it.
> 
> Please do not top post on netdev.

? I did not.

> If you cannot find best words for it, maybe a comment would not be
> useful : Very often, best comments are added by people that had problems
> to understand the code ;)

Yes that's why I asked the original author to do so - he hopefully understood
his code :-)

> 
> I do not trust comments, I prefer using "git grep" or tools like that to
> check call sites.
> 
> In this particular case this becomes clear, while being concise.
> 
> # git grep -n sock_efree

A good hint! Will use this first in the future.

Thanks,
Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html