netdev - Re: [patch net-next] switchdev: select INET in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJd2=TLTmzczSUOzwzqQ9Lanir-J5ektivqKABq-K7Fpw@mail.gmail.com>
Date:	Wed, 11 Mar 2015 09:26:25 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Scott Feldman <sfeldma@...il.com>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [patch net-next] switchdev: select INET in Kconfig

On Wed, Mar 11, 2015 at 9:20 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> Wed, Mar 11, 2015 at 04:36:16PM CET, alexei.starovoitov@...il.com wrote:
>>On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>>> This would fix randconfig compile error:
>>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>>
>>> Also it fixes following warning:
>>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>>
>>> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
>>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>>> ---
>>>  net/switchdev/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>>> index 86a47e1..3487940 100644
>>> --- a/net/switchdev/Kconfig
>>> +++ b/net/switchdev/Kconfig
>>> @@ -4,7 +4,7 @@
>>>
>>>  config NET_SWITCHDEV
>>>         bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>>> -       depends on INET
>>> +       select INET
>>
>>I believe Dave mentioned few times that 'select' is highly
>>discouraged, since it doesn't work recursively.
>>In this case only crazy config KVMTOOL_TEST_ENABLE
>>is doing 'select INET' everything else in a tree is using
>>'depends on INET'.
>>Doing 'select NET_SWITCHDEV' was wrong in the first place.
>
> Ok, so you suggest just to change this to "depends on NET_SWITCHDEV" in
> DSA and we are good?

yes. that should work.
Probably combining that line with 'depends on HAVE_NET_DSA' line
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html